Skip to content

Copy App Gateway Examples from 2018-01-01 to 2018-02-01#2822

Merged
dsgouda merged 10 commits intoAzure:masterfrom
markjbrown:master
Apr 6, 2018
Merged

Copy App Gateway Examples from 2018-01-01 to 2018-02-01#2822
dsgouda merged 10 commits intoAzure:masterfrom
markjbrown:master

Conversation

@markjbrown
Copy link
Copy Markdown
Contributor

@markjbrown markjbrown commented Apr 5, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 5, 2018 •
edited
Loading

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI AutorestCI mentioned this pull request Apr 5, 2018
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 5, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2610

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 5, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Apr 5, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci azuresdkci requested a review from dsgouda April 5, 2018 17:34
dsgouda
dsgouda suggested changes Apr 5, 2018
View reviewed changes
...ication/network/resource-manager/Microsoft.Network/stable/2018-02-01/applicationGateway.json
],
"operationId": "ApplicationGateways_Delete",
"x-ms-examples": {
"Delete ApplicationGateway": {
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Spaces are not recommended as json keys,
consider naming this as Delete ApplicationGateway
This applies to all examples here

Copy link
Copy Markdown
Contributor Author

@markjbrown markjbrown Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a new change? Every example name we have across all our specs have spaces in them.

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a new change, but moving forward it would be nice :) won't block on this

Copy link
Copy Markdown
Contributor Author

@markjbrown markjbrown Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks. I'll look at doing this in April or May version. Thanks!

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Apr 5, 2018

@lmazuel Could you take a look at the build failure here

@markjbrown
Copy link
Copy Markdown
Contributor Author

markjbrown commented Apr 6, 2018

@lmazuel if you can check on that soon I can make any corrections right away. Thanks.

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Apr 6, 2018

Looks like an issue with AutoRest itself. @olydis will fix the CI soon.

@markjbrown
Copy link
Copy Markdown
Contributor Author

markjbrown commented Apr 6, 2018

ok, understood. Am I able to submit a PR into the 2018-04-01 branch without triggering this error? I want to get these examples into that branch before its gets pushed as a new version. thanks.

@dsgouda dsgouda merged commit a6bca52 into Azure:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeepakRajendranMsft DeepakRajendranMsft Awaiting requested review from DeepakRajendranMsft

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MikhailTryakhov MikhailTryakhov

@dsgouda dsgouda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markjbrown @AutorestCI @dsgouda @MikhailTryakhov